Skip to content

8450: Improve usability of selectable action items by supporting keyboard and double-click interactions #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8450: Improve usability of selectable action items by supporting keyboard and double-click interactions #682

wants to merge 1 commit into from
+131 −13

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Oct 29, 2025 •
edited by openjdk bot
Loading

This PR adds more interaction capabilities to tree items and checkbox tables:

  • Tree items: Added support for expanding/collapsing via double-click and Enter key press.
  • Checkbox table: Added support for enabling/disabling via Enter key press.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8450: Improve usability of selectable action items by supporting keyboard and double-click interactions (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.org/jmc.git pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/682.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8450: Improve usability of selectable action items by supporting keyb… 8450: Improve usability of selectable action items by supporting keyboard and double-click interactions Oct 29, 2025
@openjdk openjdk bot added the rfr label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@aymane-harmaz
Copy link
Member Author

aymane-harmaz commented Nov 27, 2025

/keepalive

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@aymane-harmaz The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rfr

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aymane-harmaz